6 years agoFreestyle: minor UI improvements.
Tamito Kajiyama [Thu, 24 Apr 2014 14:27:58 +0000 (23:27 +0900)]
Freestyle: minor UI improvements.

* The button icon for jumping to the Render Layers tab of the Properties context is
now RENDERLAYERS.  Previous icon BUTS was too general.

* Thickness position options are grayed out if not applicable.  These options are applied
only when plain chaining is used with the Same Object option enabled.

6 years agoFix T37452: More descriptive tooltips for freestyles settings.
Tamito Kajiyama [Thu, 24 Apr 2014 14:22:21 +0000 (23:22 +0900)]
Fix T37452: More descriptive tooltips for freestyles settings.

Tool tips of some Freestyle parameters were revised so that parameter descriptions
are easier to understand for artists.

6 years agoQuiet warning
Campbell Barton [Thu, 24 Apr 2014 09:07:52 +0000 (19:07 +1000)]
Quiet warning

6 years agoFix T39830: Viewer node update error in the compositor when using the seperate/combin...
Sergey Sharybin [Thu, 24 Apr 2014 09:17:14 +0000 (15:17 +0600)]
Fix T39830: Viewer node update error in the compositor when using the seperate/combine YCbCr nodes

Mode of the YCC<->RGB was never set..

6 years agoFix T39785: Video Sequencer, Aspect Ratio issue
Sergey Sharybin [Thu, 24 Apr 2014 08:28:18 +0000 (14:28 +0600)]
Fix T39785: Video Sequencer, Aspect Ratio issue

Sequencer preview was rendering all scenes with the context
resolution, which doesn't give proper result. Now made it so
sequencer scene preview uses scene's resolution.

6 years agoFix T39786: Transform node gives bad result.
Kevin Dietrich [Thu, 24 Apr 2014 07:30:39 +0000 (09:30 +0200)]
Fix T39786: Transform node gives bad result.

Error caused by rB09874df1.

6 years agoCOmpilation error fix after recent cleanup in BGE
Sergey Sharybin [Thu, 24 Apr 2014 07:03:41 +0000 (13:03 +0600)]
COmpilation error fix after recent cleanup in BGE

6 years agoFreestyle: quiet BMESH validator warnings of zero normals.
Tamito Kajiyama [Thu, 24 Apr 2014 04:57:10 +0000 (13:57 +0900)]
Freestyle: quiet BMESH validator warnings of zero normals.

6 years agoBGE Cleanup: Moving reinstancing physics shapes from KX_ConvertPhysicsObject to PHY_I...
Mitchell Stokes [Thu, 24 Apr 2014 02:37:54 +0000 (19:37 -0700)]
BGE Cleanup: Moving reinstancing physics shapes from KX_ConvertPhysicsObject to PHY_IPhysicsController

This was the last item in KX_ConvertPhysicsObject. Therefore,
KX_ConvertPhysicsObject.h and KX_ConvertPhysicsObjects.cpp have been

6 years agoFix the classification + ordering of a few of the easing types
Joshua Leung [Thu, 24 Apr 2014 02:28:30 +0000 (14:28 +1200)]
Fix the classification + ordering of a few of the easing types

After recently reading through Robert Penner's original descriptions of these
easing equations for some other work I've been doing, I realised that the
ordering I introduced earlier was slightly off (with regards to sine and circular
types). This commit recitifies these issues.

6 years agoFix T39851: F-curve noise modifier on a bone: change selection when modifying value
Joshua Leung [Thu, 24 Apr 2014 02:26:53 +0000 (14:26 +1200)]
Fix T39851: F-curve noise modifier on a bone: change selection when modifying value

When the dopesheet was open, "keyframe edited" events from the graph editor
(i.e. fired whenever any properties on keyframes or FModifiers are changed)
would trigger the dopesheet to synchronise selection states of anim channels
and ensure that FCurve autocolours are initialised correctly.

This however was undesired when editing properties in the graph editor. Now,
made it so that keyframe adding/removing operators use different notifier flags
to specify that the channels might have changed + need colour syncing, and
adjusted the dopesheet updating logic to fit

6 years agoBGE Cleanup: Physics conversion is now handled by PHY_IPhysicsEnvironment
Mitchell Stokes [Thu, 24 Apr 2014 01:39:33 +0000 (18:39 -0700)]
BGE Cleanup: Physics conversion is now handled by PHY_IPhysicsEnvironment

The current physics conversion code was moved from
KX_ConvertPhysicsObjects to CcdPhysicsEnvironment.

6 years agoBGE Cleanup: Reducing KX_BlenderSceneConverter's dependence on Bullet.
Mitchell Stokes [Thu, 24 Apr 2014 00:53:25 +0000 (17:53 -0700)]
BGE Cleanup: Reducing KX_BlenderSceneConverter's dependence on Bullet.

  * Moving the BlenderDebugDraw (derived from btIDebugDraw) from
    KX_BlenderSceneConverter to CcdPhysicsEnvironment
  * Moving CcdPhysicsEnvironment initialization to CcdPhysicsEnvironment
    (this could probably be cleaned up some more with some sort of
    factory, or at least moving code to CcdPhysicsEnvironment's
  * Simplifying physics environment initialization (went from two
    switches to one)

6 years agoBGE Cleanup: Reducing KX_Scene's dependence on Bullet.
Mitchell Stokes [Wed, 23 Apr 2014 21:08:49 +0000 (14:08 -0700)]
BGE Cleanup: Reducing KX_Scene's dependence on Bullet.

Instead, it now relies more on our physics abstractions (e.g.,

6 years agoBGE Cleanup: Removing the empty KX_ClearBulletSharedShapes() function
Mitchell Stokes [Wed, 23 Apr 2014 20:59:04 +0000 (13:59 -0700)]
BGE Cleanup: Removing the empty KX_ClearBulletSharedShapes() function

6 years agoFix T39839: Applying the subsurf modifier deletes the freestyle edge marks
Campbell Barton [Wed, 23 Apr 2014 19:20:45 +0000 (05:20 +1000)]
Fix T39839: Applying the subsurf modifier deletes the freestyle edge marks

6 years agoSubsurf: minor optimization setting edge origindex
Campbell Barton [Wed, 23 Apr 2014 19:14:35 +0000 (05:14 +1000)]
Subsurf: minor optimization setting edge origindex

6 years agoFix T39852: Crash (Blender internal) large objects
Campbell Barton [Wed, 23 Apr 2014 17:06:02 +0000 (03:06 +1000)]
Fix T39852: Crash (Blender internal) large objects

Add check when bounds reached inf

6 years agoQuiet warnings
Campbell Barton [Wed, 23 Apr 2014 16:34:34 +0000 (02:34 +1000)]
Quiet warnings

6 years agoAdd asserts to raytrace get/set_cut functions
Campbell Barton [Wed, 23 Apr 2014 16:29:40 +0000 (02:29 +1000)]
Add asserts to raytrace get/set_cut functions

6 years agoFix T39847: Followup to rB6babb4d12b8b.
Bastien Montagne [Wed, 23 Apr 2014 15:59:35 +0000 (17:59 +0200)]
Fix T39847: Followup to rB6babb4d12b8b.

As suggested by Campbell, bump subversion and reset all ui_previews data (so that any file that could
have been corrupted in past two weeks because of this bug is fixed and valid again).

6 years agoFix T39848: Reroute nodes were not handled properly after compositor
Lukas Tönne [Wed, 23 Apr 2014 15:00:04 +0000 (17:00 +0200)]
Fix T39848: Reroute nodes were not handled properly after compositor
cleanup patch.

These simply need a proxy node, which will be replaced by direct
operation links afterward.

6 years agoFix T39828: Incorrect render layer visibility display for animated render layers.
Bastien Montagne [Wed, 23 Apr 2014 13:58:46 +0000 (15:58 +0200)]
Fix T39828: Incorrect render layer visibility display for animated render layers.

More like a workaround, current depsgraph does not really allow for animated layers,
esp. when we alwys expect at least one to be enabled (same issue as with basic Scene layers).

6 years agoFix T39781: Autosmooth feature: erroneously showing hidden vertices' normals too...
Bastien Montagne [Wed, 23 Apr 2014 13:18:11 +0000 (15:18 +0200)]
Fix T39781: Autosmooth feature: erroneously showing hidden vertices' normals too when in "vertex per face" display

So, turned out after all we need a foreachmapped helper for loops as well... :/

CDDM and EBDM were reasonably simple, but I fought hours with CCGDM (subsurf) to find only a
bad working solution (see D478). So I fallback to a code similar to CDDM one.
Probably not nice for performances, but loops and subsurf are not matching well...

Reviewers: campbellbarton

CC: brecht
Differential Revision:

6 years agoFix compilation on OSX after previous commit
Sergey Sharybin [Wed, 23 Apr 2014 13:19:02 +0000 (19:19 +0600)]
Fix compilation on OSX after previous commit

EXPECT_EQ wasn't defined in the scope.

6 years agoUpdate ffmpeg in to 2.1.4.
Bastien Montagne [Wed, 23 Apr 2014 09:06:58 +0000 (11:06 +0200)]
Update ffmpeg in to 2.1.4.

6 years agoCleanup in modifier stack evaluation: deduplicate final tessellation handling code...
Bastien Montagne [Tue, 22 Apr 2014 09:00:13 +0000 (11:00 +0200)]
Cleanup in modifier stack evaluation: deduplicate final tessellation handling code between
editmode and objectmode functions. No behavioral change expected!

6 years agoFix T39849: Adding links directly between node group input/output
Lukas Tönne [Wed, 23 Apr 2014 10:00:28 +0000 (12:00 +0200)]
Fix T39849: Adding links directly between node group input/output
extension sockets would create additional extension sockets instead of
simply ignoring them.

6 years agoLibmv cleanup: move aligned malloc implementation into own file
Sergey Sharybin [Wed, 23 Apr 2014 10:02:30 +0000 (16:02 +0600)]
Libmv cleanup: move aligned malloc implementation into own file

It was rather stupid having it in brute region tracker,
now it is in own file in base library.

6 years agoCode cleanup: style and use switch () for (un)pack
Campbell Barton [Wed, 23 Apr 2014 09:22:03 +0000 (19:22 +1000)]
Code cleanup: style and use switch () for (un)pack

6 years agoFix T39847: uiPreview not being copied with areas
Campbell Barton [Wed, 23 Apr 2014 07:13:28 +0000 (17:13 +1000)]
Fix T39847: uiPreview not being copied with areas

6 years agoQuiet warning
Campbell Barton [Wed, 23 Apr 2014 07:01:17 +0000 (17:01 +1000)]
Quiet warning

6 years agoBlender Internal: Add material property "Cast" which can disable both ray and buffer...
IRIE Shinsuke [Wed, 23 Apr 2014 06:02:06 +0000 (15:02 +0900)]
Blender Internal: Add material property "Cast" which can disable both ray and buffer shadows.

Also refactor:
- Material property UI related to shadows
- Preparation of OR-ed mode flags (ma->mode_l) of render materials

Reviewers: brecht

Reviewed By: brecht

Differential Revision:

6 years agoAdded missing property.
Tamito Kajiyama [Wed, 23 Apr 2014 05:54:43 +0000 (14:54 +0900)]
Added missing property.


6 years agoWhitespace
Joshua Leung [Wed, 23 Apr 2014 04:46:13 +0000 (16:46 +1200)]

6 years agoApplying same fix for snapping keyframes in Graph Editor
Joshua Leung [Wed, 23 Apr 2014 04:41:30 +0000 (16:41 +1200)]
Applying same fix for snapping keyframes in Graph Editor

6 years agoFix T39850: Graph Editor - 'Mirror Over First Selected Marker' mirrors over frame...
Joshua Leung [Wed, 23 Apr 2014 04:38:09 +0000 (16:38 +1200)]
Fix T39850: Graph Editor - 'Mirror Over First Selected Marker' mirrors over frame 0 instead

Problem was introduced back in 2.70 during Project Pampa when the FCurve Normalisation
feature was introduced. The cause was that the normalised cursor value was always getting
passed to the KeyframeEditData context, even when it wasn't needed.

6 years agoBGE Cleanup: Removing all of the my_* functions in KX_ConvertPhysicsObjects.cpp that...
Mitchell Stokes [Wed, 23 Apr 2014 03:36:36 +0000 (20:36 -0700)]
BGE Cleanup: Removing all of the my_* functions in KX_ConvertPhysicsObjects.cpp that were used to get bounds information

Now we just use BKE_object_boundbox_get().

6 years agoBGE Cleanup: Removing KX_ObjectProperties, KX_BoundBoxClass, KX_BoxBounds, and KX_CBounds
Mitchell Stokes [Wed, 23 Apr 2014 03:12:22 +0000 (20:12 -0700)]
BGE Cleanup: Removing KX_ObjectProperties, KX_BoundBoxClass, KX_BoxBounds, and KX_CBounds

These were used in BL_CreatePhysicsObjectNew() in the converter. However, all
of the data put into KX_ObjectProperties was then copied again in
KX_ConvertBulletObject(). So, instead KX_ConvertBulletObject() now gathers the
information it needs itself, which avoid this odd double conversion step for

As a side-effect, the old code would result in static non-mesh objects with no bounds
set to still have triangle mesh bounds. This would result in no bounds for these objects.
If a bounds was set that required a mesh, non-mesh objects would become sphere bounds.
This is now true regardless of whether user bounds were set. In other words, static
non-mesh objects now use sphere bounds by default instead of mesh bounds. This might
slightly alter some games, but these objects should generally be set to No Collision

6 years agoFix T39458: Switching physics type from Character to Dynamic enables ghost flag silently
Mitchell Stokes [Tue, 22 Apr 2014 23:38:34 +0000 (16:38 -0700)]
Fix T39458: Switching physics type from Character to Dynamic enables ghost flag silently

Enabling ghost for Sensors and Characters is now done in conversion
rather than when setting the RNA.

6 years agoCycles: some tiny hair intersection optimizations that help maybe 2%.
Brecht Van Lommel [Tue, 22 Apr 2014 23:10:26 +0000 (01:10 +0200)]
Cycles: some tiny hair intersection optimizations that help maybe 2%.

6 years agoFix occasional wrong normal for curves with minimum width.
Brecht Van Lommel [Tue, 22 Apr 2014 21:47:19 +0000 (23:47 +0200)]
Fix occasional wrong normal for curves with minimum width.

This caused a couple of fireflies in koro_final.blend. The wrong normal would
cause the shading point to be set as backfacing, which triggered another bug
with hair BSDFs on the backface of hair curves. That one is not fixed yet but
there's a comment in the code about it now.

6 years agoFix T39429: Project paint error with UV bleed
Campbell Barton [Tue, 22 Apr 2014 18:23:54 +0000 (04:23 +1000)]
Fix T39429: Project paint error with UV bleed

6 years agoApparently msvc doesn't have #warning
Sergey Sharybin [Tue, 22 Apr 2014 18:25:19 +0000 (00:25 +0600)]
Apparently msvc doesn't have #warning

It's unclear how to deal with symlinks on windows as well..

6 years agoMath Lib: move barycentric_weights_v2_persp to into math_geom
Campbell Barton [Tue, 22 Apr 2014 16:09:50 +0000 (02:09 +1000)]
Math Lib: move barycentric_weights_v2_persp to into math_geom

6 years agoCycles: optimization for hair BVH build, allow max 2 hair curves per leaf.
Brecht Van Lommel [Tue, 22 Apr 2014 14:54:02 +0000 (16:54 +0200)]
Cycles: optimization for hair BVH build, allow max 2 hair curves per leaf.

This gives me 14% reduction in render time for koro_final.blend.

6 years agoBMesh: minor optimizations for shapekey lookups on conversion
Campbell Barton [Tue, 22 Apr 2014 14:49:28 +0000 (00:49 +1000)]
BMesh: minor optimizations for shapekey lookups on conversion

6 years agoAdd type checks for Python context overrides
Campbell Barton [Tue, 22 Apr 2014 13:05:58 +0000 (23:05 +1000)]
Add type checks for Python context overrides

it was too easy to use invalid types which would crash or fail silently.

6 years agoCode cleanup: use const for rna
Campbell Barton [Tue, 22 Apr 2014 12:55:10 +0000 (22:55 +1000)]
Code cleanup: use const for rna

6 years agoView3d: api naming, for setting the view matrix.
Campbell Barton [Tue, 22 Apr 2014 11:59:43 +0000 (21:59 +1000)]
View3d: api naming, for setting the view matrix.

6 years agoOSX: tentative fix for D472, ditto creates dirs when needed automatically, also thin...
Jens Verwiebe [Tue, 22 Apr 2014 10:27:35 +0000 (12:27 +0200)]
OSX: tentative fix for D472, ditto creates dirs when needed automatically, also thin out lib. Todo: rather not build the intermediate bins with openmp dependency anyway

6 years agoCorrection to O_NOFOLLOW commit to make it more portable
Sergey Sharybin [Tue, 22 Apr 2014 08:19:54 +0000 (14:19 +0600)]
Correction to O_NOFOLLOW commit to make it more portable

6 years agoinstall_deps: update to py3.4 and numpy1.8.
Bastien Montagne [Tue, 22 Apr 2014 08:08:39 +0000 (10:08 +0200)]
install_deps: update to py3.4 and numpy1.8.

6 years agoDon't follow symlinks when writing autosave or quit.blend
Campbell Barton [Tue, 22 Apr 2014 06:56:53 +0000 (16:56 +1000)]
Don't follow symlinks when writing autosave or quit.blend

D253 from Lawrence D'Oliveiro

6 years agoCorrected the comment
Sergey Sharybin [Tue, 22 Apr 2014 07:02:39 +0000 (13:02 +0600)]
Corrected the comment

6 years agoSwitch buildbot to Python-3.4.0
Sergey Sharybin [Tue, 22 Apr 2014 07:00:35 +0000 (13:00 +0600)]
Switch buildbot to Python-3.4.0

6 years agoBLI_open: check returned value for `-1` instead of `< 0`
Campbell Barton [Tue, 22 Apr 2014 06:40:17 +0000 (16:40 +1000)]
BLI_open: check returned value for `-1` instead of `< 0`

6 years agoCode cleanup: replace int with boolean.
Tamito Kajiyama [Tue, 22 Apr 2014 00:39:21 +0000 (09:39 +0900)]
Code cleanup: replace int with boolean.

6 years agoFix T39833: Nurbs Crash
Bastien Montagne [Mon, 21 Apr 2014 21:41:39 +0000 (23:41 +0200)]
Fix T39833: Nurbs Crash

Converting empty object to mesh can generate a 'Null' BL:Mesh, we have to check against it.

6 years agoFollow up to previous commit: tweak RE_RAYTRACE_EPSILON (correction value used
Bastien Montagne [Mon, 21 Apr 2014 18:17:10 +0000 (20:17 +0200)]
Follow up to previous commit: tweak RE_RAYTRACE_EPSILON (correction value used
when checking neighbor faces against shadowing).

6 years agoFix T39735: New auto smooth creates artifacts with flat shaded faces(BI)
Bastien Montagne [Mon, 21 Apr 2014 18:09:20 +0000 (20:09 +0200)]
Fix T39735: New auto smooth creates artifacts with flat shaded faces(BI)

This actually had nothing specific to new split normals, it was an internal limitation
of BI raytracer, which would check against neighbor face shadowing only when they shared
a common vertex, now it also performs checks when both faces have a vertex with a common
"ancestor" (org index).

Note this allows to also fix same issue when using SplitEdges modifier (and potentially
others?), but only when AutoSmooth is enabled (due to some compute/mem overhead, we
do not want to enable this code systematically).

Thanks to Brecht for advices and review!

6 years agoOSX: always create a window in normal state, not fullscreen or iconized …
Jens Verwiebe [Mon, 21 Apr 2014 17:43:10 +0000 (19:43 +0200)]
OSX: always create a window in normal state, not fullscreen or iconized …

6 years agoCycles: shadow function optimization for transparent shadows (CPU only).
Brecht Van Lommel [Sat, 19 Apr 2014 15:02:30 +0000 (17:02 +0200)]
Cycles: shadow function optimization for transparent shadows (CPU only).

Old algorithm:

Raytrace from one transparent surface to the next step by step. To minimize
overhead in cases where we don't need transparent shadows, we first trace a
regular shadow ray. We check if the hit primitive was potentially transparent,
and only in that case start marching. this gives extra ray cast for the cases
were we do want transparency.

New algorithm:

We trace a single ray. If it hits any opaque surface, or more than a given
number of transparent surfaces is hit, then we consider the geometry to be
entirely blocked. If not, all transparent surfaces will be recorded and we
will shade them one by one to determine how much light is blocked. This all
happens in one scene intersection function.

Recording all hits works well in some cases but may be slower in others. If
we have many semi-transparent hairs, one intersection may be faster because
you'd be reinteresecting the same hairs a lot with each step otherwise. If
however there is mostly binary transparency then we may be recording many
unnecessary intersections when one of the first surfaces blocks all light.

We found that this helps quite nicely in some scenes, on koro.blend this can
give a 50% reduction in render time, on the pabellon barcelona scene and a
forest scene with transparent leaves it was 30%. Some other files rendered
maybe 1% or 2% slower, but this seems a reasonable tradeoff.

Differential Revision:

6 years agoCleanup: Remove OpenCL __MULTI_CLOSURE__ sanity check, not needed anymore after 04a10...
Thomas Dinges [Mon, 21 Apr 2014 16:07:43 +0000 (18:07 +0200)]
Cleanup: Remove OpenCL __MULTI_CLOSURE__ sanity check, not needed anymore after 04a10907dc41.

6 years agoFix another shading issue with new split normals (deform modifier after a subsurf...
Bastien Montagne [Mon, 21 Apr 2014 15:56:05 +0000 (17:56 +0200)]
Fix another shading issue with new split normals (deform modifier after a subsurf one).

Just always tag tessellated CDlayers as dirty when we recompute split normals!

Also simplified a bit end of mesh_calc_modifiers.

6 years agoCleanup: Pass PathState as a whole, instead of individual members.
Thomas Dinges [Mon, 21 Apr 2014 15:51:51 +0000 (17:51 +0200)]
Cleanup: Pass PathState as a whole, instead of individual members.

Differential Revision:

6 years agoBMesh Inset: remove hack to store coords in normals
Campbell Barton [Mon, 21 Apr 2014 15:21:54 +0000 (01:21 +1000)]
BMesh Inset: remove hack to store coords in normals

6 years agoGHash, Edgehash: add lookup_default() funcs.
Campbell Barton [Mon, 21 Apr 2014 14:55:30 +0000 (00:55 +1000)]
GHash, Edgehash: add lookup_default() funcs.

Returns a fallback argument when the key isn't found.

6 years agoPBVH: replace ghash with gset for storing unique faces
Campbell Barton [Mon, 21 Apr 2014 14:54:36 +0000 (00:54 +1000)]
PBVH: replace ghash with gset for storing unique faces

6 years agoFix T39793: cycles SVM shading bug with tangled up nodes after recent optimization.
Brecht Van Lommel [Mon, 21 Apr 2014 15:17:24 +0000 (17:17 +0200)]
Fix T39793: cycles SVM shading bug with tangled up nodes after recent optimization.

6 years agoBasic support for UNC paths on Windows
Andrea Weikert [Mon, 21 Apr 2014 14:49:35 +0000 (16:49 +0200)]
Basic support for UNC paths on Windows

Differential Revision:

Allows users on Windows to enter UNC paths in the filebrowser and to link to .blend files on a UNC path. Functionality is limited still, we can't browse the network yet and have no support to check user rights so far.

What works:
- enter an UNC path in the file browser manually or via copy/paste
- navigation within the UNC share subfolders
- link to a file on a UNC share

What does not (yet) work:
- browse the network for computers and shares
- browse to a folder that requires entering user credentials

Rob McKay - original patch
Campbell Barton - style fixes

Campbell Barton, Brecht van Lommel

6 years agoFix GLSL after 7765b73f6d20 (Transparent Depth).
Thomas Dinges [Mon, 21 Apr 2014 14:31:46 +0000 (16:31 +0200)]
Fix GLSL after 7765b73f6d20 (Transparent Depth).

6 years agoCode cleanup: remove old closure sampling code Cycles.
Brecht Van Lommel [Mon, 21 Apr 2014 13:53:20 +0000 (15:53 +0200)]
Code cleanup: remove old closure sampling code Cycles.

This was the original code to get things working on old GPUs, but now it is no
longer in use and various features in fact depend on this to work correctly to
the point that enabling this code is too buggy to be useful.

6 years agoCycles: add Transparent Depth output to Light Path node.
Carlo Andreacchio [Mon, 21 Apr 2014 12:20:29 +0000 (14:20 +0200)]
Cycles: add Transparent Depth output to Light Path node.

This can for example be useful if you want to manually terminate the path at
some point and use a color other than black.

Reviewed By: brecht

Differential Revision:

6 years agoCode cleanup: add some asserts and fix a typo in BVH build.
John Pavel [Mon, 21 Apr 2014 12:06:29 +0000 (14:06 +0200)]
Code cleanup: add some asserts and fix a typo in BVH build.

Reviewed By: brecht

Differential Revision:

6 years agoFix new Cycles UV Map node not working correct for bump mapping.
Kevin Dietrich [Mon, 21 Apr 2014 11:15:45 +0000 (13:15 +0200)]
Fix new Cycles UV Map node not working correct for bump mapping.

Reviewed By: brecht

Differential Revision:

6 years agoObject drawing: test the flag, without comparing the value
Campbell Barton [Mon, 21 Apr 2014 09:26:37 +0000 (19:26 +1000)]
Object drawing: test the flag, without comparing the value

6 years agoSplit Normals: more fix for EditMode shading and modifiers (subsurf special case...
Bastien Montagne [Mon, 21 Apr 2014 08:20:44 +0000 (10:20 +0200)]
Split Normals: more fix for EditMode shading and modifiers (subsurf special case, this time).

CCGDM did not generate a valid tessellated loop normals CD layer...

6 years agoCode cleanup: view2d api naming
Campbell Barton [Mon, 21 Apr 2014 08:46:52 +0000 (18:46 +1000)]
Code cleanup: view2d api naming

6 years agoLibmv: optimization of PearsonProductMomentCorrelation
Sergey Sharybin [Mon, 21 Apr 2014 08:26:06 +0000 (14:26 +0600)]
Libmv: optimization of PearsonProductMomentCorrelation

Pass the arrays by reference rather than by value,
should give some percent of speedup.

Also don't pass the dimensions to the function but
get them from the images themselves.

Hopefully this will give some %% of tracker speedup.

6 years agoFix player build.
Bastien Montagne [Mon, 21 Apr 2014 08:18:51 +0000 (10:18 +0200)]
Fix player build.

6 years agoView2d: check UI_view2d_view_to_region_clip succeeds before using the result
Campbell Barton [Mon, 21 Apr 2014 08:11:47 +0000 (18:11 +1000)]
View2d: check UI_view2d_view_to_region_clip succeeds before using the result

6 years agoView2d: API Cleanup for view<->region conversion
Campbell Barton [Mon, 21 Apr 2014 06:47:16 +0000 (16:47 +1000)]
View2d: API Cleanup for view<->region conversion

View2D had some inconsistencies making it error prone in some cases.

- Inconstant checking for NULL x/y args.
  Disallow NULL args for x/y destination pointers, instead add:
  - UI_view2d_region_to_view_x/y
  - UI_view2d_view_to_region_x/y

- '_no_clip' suffix wasn't always used for non-clipping conversion,
  switch it around and use a '_clip' suffix for all funcs that clip.

- UI_view2d_text_cache_add now clips before adding cache.

- '_clip' funcs return a bool to quickly check if its in the view.

- add conversion for rectangles, since this is a common task:
  - UI_view2d_view_to_region_rcti
  - UI_view2d_region_to_view_rctf

6 years agoFix T39818: Strips from file with long filename broke auto-naming - animation can...
Bastien Montagne [Mon, 21 Apr 2014 06:30:20 +0000 (08:30 +0200)]
Fix T39818: Strips from file with long filename broke auto-naming - animation can't be apply on it.

6 years agoFix for UI_view2d_to_region_float (was ignoring x,y args)
Campbell Barton [Mon, 21 Apr 2014 04:30:13 +0000 (14:30 +1000)]
Fix for UI_view2d_to_region_float (was ignoring x,y args)

use this for grease pencil stroke conversion to avoid float->int->float conversion.

6 years agoSkin mark/clear: replace GHash with GSet
Campbell Barton [Mon, 21 Apr 2014 03:10:38 +0000 (13:10 +1000)]
Skin mark/clear: replace GHash with GSet

6 years agoFix stupid typo that broke split normal shading in edit mode, when there was some...
Bastien Montagne [Sun, 20 Apr 2014 21:12:18 +0000 (23:12 +0200)]
Fix stupid typo that broke split normal shading in edit mode, when there was some deform modifiers.

6 years agoFix incorrect ghash free
Campbell Barton [Sun, 20 Apr 2014 18:00:35 +0000 (04:00 +1000)]
Fix incorrect ghash free

6 years agoGHash, EdgeHash: hint on unlikely branch
Campbell Barton [Sun, 20 Apr 2014 16:50:07 +0000 (02:50 +1000)]
GHash, EdgeHash: hint on unlikely branch

also avoid searching buckets for empty hashes

6 years agoCorrect cast from recent bool changes
Campbell Barton [Sun, 20 Apr 2014 16:48:39 +0000 (02:48 +1000)]
Correct cast from recent bool changes

6 years agoCode cleanup: correct abs use
Campbell Barton [Sun, 20 Apr 2014 15:54:52 +0000 (01:54 +1000)]
Code cleanup: correct abs use

also minor cleanup to rotation code

6 years agoCode cleanup: style
Campbell Barton [Sun, 20 Apr 2014 12:05:05 +0000 (22:05 +1000)]
Code cleanup: style

6 years agoNodes: make default group nodes slighly wider, to match other node width defaults.
Brecht Van Lommel [Sun, 20 Apr 2014 12:36:09 +0000 (14:36 +0200)]
Nodes: make default group nodes slighly wider, to match other node width defaults.

6 years agoFix error making datablock with fake user local, the user count would be wrong afterw...
Brecht Van Lommel [Sun, 20 Apr 2014 12:33:27 +0000 (14:33 +0200)]
Fix error making datablock with fake user local, the user count would be wrong afterwards.

6 years agoMath Lib: faster version of rotation_between_vecs_to_mat3
Campbell Barton [Sun, 20 Apr 2014 10:56:09 +0000 (20:56 +1000)]
Math Lib: faster version of rotation_between_vecs_to_mat3

Use axis/angle calculation but avoid calls to sin/cos

6 years agoBGE: Fixing memory leaks when deactivating Sensors, Controllers, or actuators.
Mitchell Stokes [Sat, 19 Apr 2014 21:51:29 +0000 (14:51 -0700)]
BGE: Fixing memory leaks when deactivating Sensors, Controllers, or actuators.

Found by Coverity and confirmed with Valgrind.

6 years agoMath Lib: add shell_v3v3_normalized_to_dist and v2 version
Campbell Barton [Sat, 19 Apr 2014 12:12:50 +0000 (22:12 +1000)]
Math Lib: add shell_v3v3_normalized_to_dist and v2 version

bypass angle calculation to avoids (asin, sqrt, cos).

6 years agoBullet: making bullet friction workaround more furureproof by using the __apple_build...
Jens Verwiebe [Sat, 19 Apr 2014 12:10:49 +0000 (14:10 +0200)]
Bullet: making bullet friction workaround more furureproof by using the __apple_build_version__ macro, TODO: check if problem persists with newer clang

6 years agoMinor change to recent commit (avoid transpose)
Campbell Barton [Sat, 19 Apr 2014 09:48:07 +0000 (19:48 +1000)]
Minor change to recent commit (avoid transpose)

6 years agoMath Lib: minor optimization to barycentric_transform
Campbell Barton [Sat, 19 Apr 2014 05:50:41 +0000 (15:50 +1000)]
Math Lib: minor optimization to barycentric_transform

replace rotation_between_vecs_to_quat with axis_dominant_v3_to_m3.