6 years agobuildbot: fix: cmake generator is kind of sensitive
Martijn Berger [Tue, 11 Nov 2014 10:35:38 +0000 (11:35 +0100)]
buildbot: fix: cmake generator is kind of sensitive

6 years agoFix T41873: Different 'seed' values do not yield different noise patterns when using...
Dalai Felinto [Tue, 11 Nov 2014 12:52:58 +0000 (10:52 -0200)]
Fix T41873: Different 'seed' values do not yield different noise patterns when using cycles texture bake

As per instructions by Brecht Van Lommel.

6 years agoAdd msbuild for windows cmake buildbots
Martijn Berger [Tue, 11 Nov 2014 10:22:49 +0000 (11:22 +0100)]
Add msbuild for windows cmake buildbots

6 years agoFix T42557: Crash on delete or separate vertices with subsurf modifier + vertex parenting
Bastien Montagne [Tue, 11 Nov 2014 08:45:27 +0000 (09:45 +0100)]
Fix T42557: Crash on delete or separate vertices with subsurf modifier + vertex parenting

Only fixes the crash actually, real issue is, vparent does not handle deletion of vertices
at all currently... We'd need either some kind of static uuid for vertices, or some
mapping helpers used each time we remove or reorder verts... ugh.

Org patch by Severin (Julian Eisel).

6 years agoUI Refactor T41640
Campbell Barton [Sun, 9 Nov 2014 20:20:40 +0000 (21:20 +0100)]
UI Refactor T41640

Make the UI API more consistent and reduce confusion with some naming.

- API function calls
- enum values

some internal static functions have been left for now

6 years agoFix T39144: text-select scrolling too fast
Campbell Barton [Mon, 10 Nov 2014 19:56:17 +0000 (20:56 +0100)]
Fix T39144: text-select scrolling too fast

Use a timer to get predictable speed.

6 years agoFix T42498: Disable Renaming for Read-Only Files in File Browser
julianeisel [Mon, 10 Nov 2014 19:29:44 +0000 (20:29 +0100)]
Fix T42498: Disable Renaming for Read-Only Files in File Browser

6 years agoSequencer: undefine SEQ_BEGIN/SEQ_END (see comment)
Campbell Barton [Mon, 10 Nov 2014 18:39:20 +0000 (19:39 +0100)]
Sequencer: undefine SEQ_BEGIN/SEQ_END (see comment)

6 years agoSphinx doc script: server path has changed
Campbell Barton [Mon, 10 Nov 2014 18:27:23 +0000 (19:27 +0100)]
Sphinx doc script: server path has changed

6 years agoFix T42499: Make sure directories are not interpreted as libraries
julianeisel [Mon, 10 Nov 2014 17:51:56 +0000 (18:51 +0100)]
Fix T42499: Make sure directories are not interpreted as libraries

6 years agoCycles: Speedup for homogenous volumes in decoupled volume sampling
Sergey Sharybin [Mon, 10 Nov 2014 08:54:55 +0000 (09:54 +0100)]
Cycles: Speedup for homogenous volumes in decoupled volume sampling

The idea is to avoid memory allocation when only one segment step is to be allocated.
This gives some speedup which is difficult to measure on this trashcan from hell, but
it's about from 7% to 10% in the extreme case with single volume filling the whole of
the viewport. This seems to depends on the phase of the bug-o-meter in the studio.

On the linux boxes it's not that spectacular speedup, it's about 2% on my laptop and
about 3% on the studio desktop. This is likely because of the awesomeness of jemalloc.

6 years agoFix T4256: Connect tool hangs
Campbell Barton [Mon, 10 Nov 2014 17:38:46 +0000 (18:38 +0100)]
Fix T4256: Connect tool hangs

6 years agoFix/workaround T37073: Crash updating custom props visible in the UI
Campbell Barton [Mon, 10 Nov 2014 16:10:58 +0000 (17:10 +0100)]
Fix/workaround T37073: Crash updating custom props visible in the UI

6 years agoFix T42199: PET displays when transforming around centers
Campbell Barton [Mon, 10 Nov 2014 13:37:53 +0000 (14:37 +0100)]
Fix T42199: PET displays when transforming around centers

Old code only worked for faces.

6 years agoFix T42221: 'Shadow Width' influences tooltip size
Campbell Barton [Mon, 10 Nov 2014 12:58:03 +0000 (13:58 +0100)]
Fix T42221: 'Shadow Width' influences tooltip size

Positioning of popups was using shadow width for placement,
could give some quite odd results.

6 years agoCorrect last commit
Campbell Barton [Mon, 10 Nov 2014 12:48:27 +0000 (13:48 +0100)]
Correct last commit

6 years agoFix: Shapekey Basis not updated on editmode exit
Campbell Barton [Mon, 10 Nov 2014 12:32:39 +0000 (13:32 +0100)]
Fix: Shapekey Basis not updated on editmode exit

6 years agoFix T42486: Array modifier cap-end crash
Campbell Barton [Mon, 10 Nov 2014 08:55:25 +0000 (09:55 +0100)]
Fix T42486: Array modifier cap-end crash

Thanks to @PatB for the fix.

6 years agoCleanup: remove unused UI_SHIFT_FLIPPED (2.4x toolbox)
Campbell Barton [Sun, 9 Nov 2014 16:16:46 +0000 (17:16 +0100)]
Cleanup: remove unused UI_SHIFT_FLIPPED (2.4x toolbox)

6 years agoGLSL: specular transparency support for Blender internal materials
Dontsov Valentin [Sun, 9 Nov 2014 14:22:44 +0000 (15:22 +0100)]
GLSL: specular transparency support for Blender internal materials

Reviewed By: brecht

Differential Revision:

6 years agoFix T42540: save_pre and save_post handlers not called when saving startup.blend.
Brecht Van Lommel [Sun, 9 Nov 2014 14:11:40 +0000 (15:11 +0100)]
Fix T42540: save_pre and save_post handlers not called when saving startup.blend.

6 years agoFix T42548: crash showing subsurf modifier UI on hidden object.
Brecht Van Lommel [Sun, 9 Nov 2014 13:52:52 +0000 (14:52 +0100)]
Fix T42548: crash showing subsurf modifier UI on hidden object.

6 years agoCode cleanup: Remove unused functions from implicit.c
Sergey Sharybin [Fri, 31 Oct 2014 22:26:50 +0000 (03:26 +0500)]
Code cleanup: Remove unused functions from implicit.c

Most of the unused functions were removed. Some of them were if-defed
because they are referenced from the code which was already if-defed.

Reviewers: lukastoenne, campbellbarton

Differential Revision:

6 years agoCmake cleanup
Martijn Berger [Sat, 8 Nov 2014 20:17:04 +0000 (21:17 +0100)]
Cmake cleanup
Move compiler warnings for msvc to common compilerwarnings.

6 years agoPut latest buildbot config files to git
Sergey Sharybin [Sat, 8 Nov 2014 19:11:50 +0000 (00:11 +0500)]
Put latest buildbot config files to git

6 years agoCycles: Remove dead branch for Distant lamps, ls->t is always FLT_MAX here.
Thomas Dinges [Sat, 8 Nov 2014 15:47:56 +0000 (16:47 +0100)]
Cycles: Remove dead branch for Distant lamps, ls->t is always FLT_MAX here.

6 years agoReadme for Blender 2.73.
Thomas Dinges [Sat, 8 Nov 2014 15:47:05 +0000 (16:47 +0100)]
Readme for Blender 2.73.

6 years agoAdd safe_normalize to cycles, avoid checking length first
Campbell Barton [Sat, 8 Nov 2014 12:35:21 +0000 (13:35 +0100)]
Add safe_normalize to cycles, avoid checking length first

This won't give any big speedup,
just avoids redundant sqrtf and may be useful in future.

Differential Revision:

6 years agoCleanup: cycles whitespace
Campbell Barton [Sat, 8 Nov 2014 12:28:40 +0000 (13:28 +0100)]
Cleanup: cycles whitespace

6 years agocmake buildfiles Cleanup / Refactor, no functional changes.
Martijn Berger [Sat, 8 Nov 2014 10:32:32 +0000 (11:32 +0100)]
cmake buildfiles Cleanup / Refactor, no functional changes.
Move away from using hardcoded ${target} when calling install() in cmake

6 years agoFix T42531: Setting 'Undo' steps to '1' causes weirdness.
Bastien Montagne [Fri, 7 Nov 2014 09:24:11 +0000 (10:24 +0100)]
Fix T42531: Setting 'Undo' steps to '1' causes weirdness.

Do not allow '1' value here, it's useless.

Thanks to Campbell for suggested solution here!

6 years agoCycles: Tweak to the expf() speed workaround
Sergey Sharybin [Fri, 7 Nov 2014 08:35:45 +0000 (13:35 +0500)]
Cycles: Tweak to the expf() speed workaround

Add compile-time check for particular glibc version which fixed the issue.
This makes it so own-compiled blender is the fastest in the world, and the
only issue remains what should we do for release builds.

After some discussion with Campbell we decided to keep it as is for now
because slowdown is not that much noticeable. We'll disable this workaround
for release builds when all the majority of the distros will switch to the
new version of glibc.

6 years agoFix assert failure in GPU codegen
Sergey Sharybin [Fri, 7 Nov 2014 08:17:26 +0000 (13:17 +0500)]
Fix assert failure in GPU codegen

Even though GLSL allows to have polymorphic functions our codegen
is not aware of this at all.

Let's rename the functions for now, but in the future would be handy
to make codegen aware of the polymorphic functions.

6 years agoFix T42208 color pickers are coupled.
Antony Riakiotakis [Thu, 6 Nov 2014 19:19:21 +0000 (20:19 +0100)]
Fix T42208 color pickers are coupled.

Decouple color picker hsv data from the whole block. Basically, each
color picker now takes care of creating its own color picker role. For
this bug report it can be seen that probably HSV is not the best space
for gamma/lift/gain workflow because it is bounded at 1.0 but this is a
separate issue.

6 years agobetter fix for fix T42525 (tm)
Antony Riakiotakis [Thu, 6 Nov 2014 16:55:55 +0000 (17:55 +0100)]
better fix for fix T42525 (tm)

Looks like material node trees are stored directly in the material. The
reason I thought this was fixed was because my test file didn't connect
the lamp data node in the rest of the tree.

Thanks to Campbell for catching this :)

6 years agoFix T42497: Enlarge rename text field in File Browser
julianeisel [Thu, 6 Nov 2014 16:45:32 +0000 (17:45 +0100)]
Fix T42497: Enlarge rename text field in File Browser

To ensure there's space for more than a few characters in the rename text fields of the File Browser, we now use a width relative to the column width (for all display modes).

Includes some edits from @campbellbarton - thanks for this!

6 years agoFix T42525 crash when deleting lamp attached to Lamp Data material node
Antony Riakiotakis [Thu, 6 Nov 2014 15:38:31 +0000 (16:38 +0100)]
Fix T42525 crash when deleting lamp attached to Lamp Data material node
in material shading mode.

6 years agoEditmesh: select more/less can now step over adjacent faces
Campbell Barton [Thu, 6 Nov 2014 14:17:16 +0000 (15:17 +0100)]
Editmesh: select more/less can now step over adjacent faces

This keeps a square shaped selection when using grid topology.

6 years agoFix T42492, Shading error with fresnel weight node.
Antony Riakiotakis [Thu, 6 Nov 2014 14:03:34 +0000 (15:03 +0100)]
Fix T42492, Shading error with fresnel weight node.

Orthographic case needs different handling.

6 years agoRevert "Metastrips: disallow making a metastrip with only one strip present."
Antony Riakiotakis [Thu, 6 Nov 2014 13:06:24 +0000 (14:06 +0100)]
Revert "Metastrips: disallow making a metastrip with only one strip present."

This reverts commit a1578f08dc442b0c64f05a1ab18ef0fd90a9f6e4.

Looks like some workflows benefit from being able to do this

6 years agoSlight corrections to the string formatting of autosave, thanks to
Antony Riakiotakis [Thu, 6 Nov 2014 12:08:43 +0000 (13:08 +0100)]
Slight corrections to the string formatting of autosave, thanks to
Campbell for the help!

6 years agoGooseberry request, append the file name to autosaves as well as the pid
Antony Riakiotakis [Thu, 6 Nov 2014 11:42:47 +0000 (12:42 +0100)]
Gooseberry request, append the file name to autosaves as well as the pid

6 years agoCorrect recent refactor (use generic callback)
Campbell Barton [Thu, 6 Nov 2014 10:47:08 +0000 (11:47 +0100)]
Correct recent refactor (use generic callback)

6 years agoCycles: Add "Max Bounce" control for lamps
Thomas Dinges [Wed, 5 Nov 2014 21:48:45 +0000 (22:48 +0100)]
Cycles: Add "Max Bounce" control for lamps

With this setting, we can limit the influence of a lamp to a certain amount of bounces.
0 = Only direct light contribution
1 = 1 light bounce

Differential revision:

You can find an example render in the release logs:

6 years agoFixed warning about redefining the __SSE__ macro in VS2013
Sybren A. Stüvel [Wed, 5 Nov 2014 16:09:27 +0000 (17:09 +0100)]
Fixed warning about redefining the __SSE__ macro in VS2013

6 years agoFix T42255: "Copy Constraints" operator has to tag the affected object
Lukas Tönne [Wed, 5 Nov 2014 13:51:02 +0000 (14:51 +0100)]
Fix T42255: "Copy Constraints" operator has to tag the affected object
and pose for depsgraph.

Otherwise the update order can be incorrect until the next sort is

6 years agoEditmesh: report a warning when fill fails
Campbell Barton [Wed, 5 Nov 2014 13:19:14 +0000 (14:19 +0100)]
Editmesh: report a warning when fill fails

also prevent assert with zero normal

6 years agoDebug: print output on --debug-fpe
Campbell Barton [Wed, 5 Nov 2014 11:27:38 +0000 (12:27 +0100)]
Debug: print output on --debug-fpe

in practice often we want to breakpoint here (instead of flooding output)
but its confusing the option does nothing in release builds.

Devs can comment out locally.

6 years agoSimplify node frame detach operators, based on T34670 by @julien.
Lukas Tönne [Wed, 5 Nov 2014 10:35:48 +0000 (11:35 +0100)]
Simplify node frame detach operators, based on T34670 by @julien.

* The `NODE_OT_parent_clear` operator has been removed. This was a very
simplistic operator that detached every selected node, which is not very
useful in case of hierarchical frames. The `NODE_OT_detach` operator
only detaches the top parent nodes in the selection, keeping the
hierarchy of selected nodes intact.

* The `ALT+P` shortcut has been reassigned to the `NODE_OT_detach`
operator which replaces the previous `NODE_OT_clear` mapping with
similar behavior (also gives a menu entry shortcut now).

* Shortcuts for `NODE_OT_detach_translate_attach` have been removed, due
to crowded and messy keymap and unintuitive shortcut `ALT+F`. This macro
operator is still registered, in case hardcore users want to make their
own keymaps, but not mapped by default. Node keymaps may need some
redesign in the future for these things.

6 years agoCode cleanup: Replace magic number with verbose name for math node operations
Sergey Sharybin [Wed, 5 Nov 2014 10:27:52 +0000 (11:27 +0100)]
Code cleanup: Replace magic number with verbose name for math node operations

Should be no functional changes, just much less cryptic code.

6 years agoCycles: Don't check shader for volume when checking if camera is inside volume
Sergey Sharybin [Tue, 4 Nov 2014 18:57:15 +0000 (19:57 +0100)]
Cycles: Don't check shader for volume when checking if camera is inside volume

Intersection code already ignores objects without volume closure so checking it
afterwards is not needed.

6 years agoFix T42411: Camera inside volume + particle dupli (object/group) doesn't work
Sergey Sharybin [Tue, 4 Nov 2014 18:55:05 +0000 (19:55 +0100)]
Fix T42411: Camera inside volume + particle dupli (object/group) doesn't work

The issue was caused by missing current object instance initialization after
object was ignored for instance push.

6 years agoBMesh dissolve: enable use_verts for edge dissolve (by default)
Campbell Barton [Tue, 4 Nov 2014 16:05:23 +0000 (17:05 +0100)]
BMesh dissolve: enable use_verts for edge dissolve (by default)

6 years agoFix T42408: FSAA affects Cycles Image Compositing
Sergey Sharybin [Tue, 4 Nov 2014 15:41:12 +0000 (20:41 +0500)]
Fix T42408: FSAA affects Cycles Image Compositing

Use FSAA settings only if current render engine is BI or GE/

That's for until we'll support FSAA in Cycles or other render engines.

6 years agoFix T42289: 'Make single user' not registered in history
Sergey Sharybin [Tue, 4 Nov 2014 13:52:38 +0000 (18:52 +0500)]
Fix T42289: 'Make single user' not registered in history

6 years agoFix-for-fix ik-spline clamp existing files too
Campbell Barton [Tue, 4 Nov 2014 13:03:58 +0000 (14:03 +0100)]
Fix-for-fix ik-spline clamp existing files too

6 years agoFix T42445: Clamp flag has no effect on result value in Math and MixRGB shader nodes...
Sergey Sharybin [Tue, 4 Nov 2014 11:50:29 +0000 (16:50 +0500)]
Fix T42445: Clamp flag has no effect on result value in Math and MixRGB shader nodes (Blender Render)

Quite striaghtforward implementation, with the only weird thing that for some reason
my video driver wasn't happy with calling the function "clamp" giving some weirdo
shader compilation error messages.

Called the GPU function clamp_val which can handle float and vec3.

6 years agoAdd utility macros to clamp all elements of 2,3,4 component vectors
Sergey Sharybin [Tue, 4 Nov 2014 11:31:42 +0000 (16:31 +0500)]
Add utility macros to clamp all elements of 2,3,4 component vectors

6 years agoCode cleanup: Replace magic constants with defines
Sergey Sharybin [Tue, 4 Nov 2014 11:28:16 +0000 (16:28 +0500)]
Code cleanup: Replace magic constants with defines

From quich search didn't see where the flags are used apart from
RNA currently, but i might have missed something.

6 years agoCycles: Remove compatibility code for OSL-1.4
Sergey Sharybin [Tue, 4 Nov 2014 10:52:41 +0000 (15:52 +0500)]
Cycles: Remove compatibility code for OSL-1.4

That code was mainly needed for the transition period, now we've
got all platforms updated to new OSL.

Plus there are some crucial fixes baking in the current upstream
sources which we'll need to have for the next Blender release.

6 years agoCycles: Be ready for new OIIO and OSL libraries
Sergey Sharybin [Tue, 4 Nov 2014 10:49:28 +0000 (15:49 +0500)]
Cycles: Be ready for new OIIO and OSL libraries

Even tho it's not 100% clear when we'll switch to OSL-1.6 we'd better
start preparing earlier for this, so we don't spend time on this later.

Plus this code helps troubleshooting some OSL issues, which requires
testing with latest versions of OSL.

6 years agoCleanup for previous own commit (sorry...)
Bastien Montagne [Tue, 4 Nov 2014 09:31:59 +0000 (10:31 +0100)]
Cleanup for previous own commit (sorry...)

6 years agoAdd missing `CustomData_duplicate_referenced_layer_n` and deduplicate code.
Bastien Montagne [Tue, 4 Nov 2014 09:06:08 +0000 (10:06 +0100)]
Add missing `CustomData_duplicate_referenced_layer_n` and deduplicate code.

CustomData_duplicate_referenced_layer_n not used in master currently, but need it
in mesh tranfer branch.

6 years agoFix use-after free (own error)
Campbell Barton [Tue, 4 Nov 2014 08:48:41 +0000 (09:48 +0100)]
Fix use-after free (own error)

6 years agoCMake: Attempted to copy manual for py-module
Campbell Barton [Tue, 4 Nov 2014 08:37:01 +0000 (09:37 +0100)]
CMake: Attempted to copy manual for py-module

6 years agoCleanup: spelling (D831)
Campbell Barton [Mon, 3 Nov 2014 22:26:43 +0000 (23:26 +0100)]
Cleanup: spelling (D831)

6 years agoFix T42233: Python property ignores 'PROPORTIONAL'
Campbell Barton [Mon, 3 Nov 2014 19:56:52 +0000 (20:56 +0100)]
Fix T42233: Python property ignores 'PROPORTIONAL'

6 years agoOptimization of parallel range
Sergey Sharybin [Mon, 3 Nov 2014 17:24:08 +0000 (18:24 +0100)]
Optimization of parallel range

It now supports different scheduling schemas: dynamic and static.
Static one is the default and it splits work into equal number of
range iterations.

Dynamic one allocates chunks of 32 iterations which then being
dynamically send to a thread which is currently idling.

This gives slightly better performance. Still some tricks are
possible to have. For example we can use some smarter static scheduling
when one thread might steal tasks from another threads when it runs
out of work to be done.

Also removed unneeded spin lock in the mesh deform evaluation,
on the first glance it seemed to be a reduction involved here but
int fact threads are just adding value to the original vertex
coordinates. No write access to the same element of  vertexCos
happens from separate threads.

6 years agoCleanup: remove rarely used IDProp iterator
Campbell Barton [Mon, 3 Nov 2014 16:04:12 +0000 (17:04 +0100)]
Cleanup: remove rarely used IDProp iterator

6 years agoCleanup: defines -> enums, bitshifts for bitflags definitions.
Bastien Montagne [Mon, 3 Nov 2014 15:48:06 +0000 (16:48 +0100)]
Cleanup: defines -> enums, bitshifts for bitflags definitions.

6 years agoFix indetation in last commit
Jens Verwiebe [Mon, 3 Nov 2014 14:06:46 +0000 (15:06 +0100)]
Fix indetation in last commit

6 years agoOSX/fsmenu: fix compiling on older gcc reported by Mike S
Jens Verwiebe [Mon, 3 Nov 2014 14:05:48 +0000 (15:05 +0100)]
OSX/fsmenu: fix compiling on older gcc reported by Mike S

6 years agoCompilation error fix for buildbot
Sergey Sharybin [Mon, 3 Nov 2014 10:24:53 +0000 (15:24 +0500)]
Compilation error fix for buildbot

Ghost depends on glew-mx, so glew-mx should be passed to linker after the ghost.

We're also using spaces for indentation in python, including scons rules.

6 years agoBMesh: arg reorder
Campbell Barton [Mon, 3 Nov 2014 07:30:33 +0000 (08:30 +0100)]
BMesh: arg reorder

6 years agoFix typo breaking compilation with SSE2.
Bastien Montagne [Sun, 2 Nov 2014 21:59:33 +0000 (22:59 +0100)]
Fix typo breaking compilation with SSE2.

Spotted by sybrenstuvel (Sybren Stüvel), thanks!

6 years agoFix connect-vertices failing for concave ngons
Campbell Barton [Sat, 1 Nov 2014 22:31:01 +0000 (23:31 +0100)]
Fix connect-vertices failing for concave ngons

Also add:
- generic callback for bmesh elements.
- ability to pass an existing array to a bmesh operator.

6 years agoOpenGL: double width lines is no-longer apple-only
Campbell Barton [Sat, 1 Nov 2014 15:16:46 +0000 (16:16 +0100)]
OpenGL: double width lines is no-longer apple-only

6 years agoFix for 3D Ruler crash maximizing view
Campbell Barton [Sat, 1 Nov 2014 15:06:14 +0000 (16:06 +0100)]
Fix for 3D Ruler crash maximizing view

6 years agoCleanup: style
Campbell Barton [Sat, 1 Nov 2014 13:31:09 +0000 (14:31 +0100)]
Cleanup: style

6 years agoCleanup: mostly use bools for booleans.
Bastien Montagne [Sat, 1 Nov 2014 21:25:57 +0000 (22:25 +0100)]
Cleanup: mostly use bools for booleans.

6 years agoCleanup/fix from latest coverity report.
Bastien Montagne [Sat, 1 Nov 2014 15:34:35 +0000 (16:34 +0100)]
Cleanup/fix from latest coverity report.

Mostly harmless things, though the 'multires' error was a real bug.

6 years agoCycles: Remove redundant alloc/free
Sergej Reich [Sat, 1 Nov 2014 14:23:14 +0000 (15:23 +0100)]
Cycles: Remove redundant alloc/free

Seems like a copy paste error.

6 years agoLibmv: Code cleanup, avoid C11 feature with structure re-definition
Sergey Sharybin [Fri, 31 Oct 2014 22:18:40 +0000 (03:18 +0500)]
Libmv: Code cleanup, avoid C11 feature with structure re-definition

6 years agoCycles: Code cleanup, proper class vs. struct declaration
Sergey Sharybin [Fri, 31 Oct 2014 22:09:46 +0000 (03:09 +0500)]
Cycles: Code cleanup, proper class vs. struct declaration

6 years agoLibmv: Code cleanup, mixed class/struct in declaration/definition
Sergey Sharybin [Fri, 31 Oct 2014 21:53:36 +0000 (02:53 +0500)]
Libmv: Code cleanup, mixed class/struct in declaration/definition

6 years agoCleanup: Remove unused light function.
Thomas Dinges [Fri, 31 Oct 2014 21:54:05 +0000 (22:54 +0100)]
Cleanup: Remove unused light function.

6 years agoOptimize vertex parent for edit mode without modifiers
Sergey Sharybin [Fri, 31 Oct 2014 19:15:32 +0000 (20:15 +0100)]
Optimize vertex parent for edit mode without modifiers

No need to run lookup on the origindex in this case at all.

6 years agoOptimize vertex parent in cases there are only deform and SS modifiers
Sergey Sharybin [Fri, 31 Oct 2014 19:06:19 +0000 (20:06 +0100)]
Optimize vertex parent in cases there are only deform and SS modifiers

In cases when the subsurf modifier is the last in the stack and there
are only deformation modifiers before it we can skip doing full orig
vertex lookup.

This is rather common situation here in animatic.

6 years agoSCons: Expose missing command line arguments controlling GLEW
Sergey Sharybin [Fri, 31 Oct 2014 17:34:25 +0000 (22:34 +0500)]
SCons: Expose missing command line arguments controlling GLEW

6 years agoFix T42349: Windows Render command line Cycles Crash
Sergey Sharybin [Fri, 31 Oct 2014 17:28:39 +0000 (22:28 +0500)]
Fix T42349: Windows Render command line Cycles Crash

The issue was caused by GLEW MX enabled in SCons by default so
basically previous commit already fixed the crash. But we need
to be safe here.

For now the fix is simple and not that clean, just check if
there's an OpenGL context available and if not we don't do any
GLSL magic.

This is to be cleaned up after some discussion with the viewport
project guys.

6 years agoDisable GLEW_MX in scons
Sergey Sharybin [Fri, 31 Oct 2014 17:12:21 +0000 (22:12 +0500)]
Disable GLEW_MX in scons

This was already disabled in CMake and we need to keep build systems
in 100% synchronized state.

P.S. Would it be a real fix to drop SCons?

6 years agoFollowup to rB154af70f2b5b7b: always 'pack in' ongoing versionning code when bumping...
Bastien Montagne [Fri, 31 Oct 2014 17:26:58 +0000 (18:26 +0100)]
Followup to rB154af70f2b5b7b: always 'pack in' ongoing versionning code when bumping version.

6 years agoThemes auto-update from py script.
Bastien Montagne [Fri, 31 Oct 2014 17:14:20 +0000 (18:14 +0100)]
Themes auto-update from py script.

6 years agoFix T42454: Themes: Some colors were missed somehow in an update two years ago.
Bastien Montagne [Fri, 31 Oct 2014 17:12:28 +0000 (18:12 +0100)]
Fix T42454: Themes: Some colors were missed somehow in an update two years ago.

Had to fix it by hand (restting them to default values), theme maintainers,
please check your theme from time to time and track such ugly 'pitch black' fields.

And we devs should run theme update script much more often too - will do in next commit!

6 years agoFix T42432: Correct BLENDER_SUBVERSION
julianeisel [Fri, 31 Oct 2014 16:54:18 +0000 (17:54 +0100)]

Bump up BLENDER_SUBVERSION to 2 to allow saving of widget emboss.

6 years agoCleanup: naming
Campbell Barton [Fri, 31 Oct 2014 14:32:59 +0000 (15:32 +0100)]
Cleanup: naming

6 years agoCode cleanup: synchronize const qualifiers between declaration and definition
Sergey Sharybin [Fri, 31 Oct 2014 15:17:02 +0000 (16:17 +0100)]
Code cleanup: synchronize const qualifiers between declaration and definition

6 years agoCode cleanup: Remove unused variable
Sergey Sharybin [Fri, 31 Oct 2014 15:13:13 +0000 (16:13 +0100)]
Code cleanup: Remove unused variable

6 years agoCompositor: Don't let HSV correction to output negative colors
Sergey Sharybin [Fri, 31 Oct 2014 13:51:59 +0000 (14:51 +0100)]
Compositor: Don't let HSV correction to output negative colors

6 years agoFix T42391: HSV correction shader node gives negative values
Sergey Sharybin [Fri, 31 Oct 2014 13:42:48 +0000 (14:42 +0100)]
Fix T42391: HSV correction shader node gives negative values

This mainly happens when over-saturating already saturated color.
After some discussion with Campbell and loads of tests we decided
to clamp the result RGB color. As an alternative we might want to
clamp corrected HSV values instead, but that would lead to some
larger changes in the render results.

TODO: The same is to be done for compositor nodes.