blender.git
2 days agoMerge branch 'master' into sculpt-mode-features sculpt-mode-features
Pablo Dobarro [Sat, 22 Jun 2019 16:30:34 +0000 (18:30 +0200)]
Merge branch 'master' into sculpt-mode-features

2 days agoGPencil: Fix Fast Drawing and MSAA disabled in previous commit
Antonioya [Sat, 22 Jun 2019 15:47:00 +0000 (17:47 +0200)]
GPencil: Fix Fast Drawing and MSAA disabled in previous commit

The previous commit disable the fast drawing if the background texture was not ready, but it did not detect the Painting mode, so the fast was always disabled.

Now the check is done inside paint mode.

2 days agoGPencil: Don't use MSAA for background texture
Antonioya [Sat, 22 Jun 2019 15:11:53 +0000 (17:11 +0200)]
GPencil: Don't use MSAA for background texture

This texture has already the MSAA applied.

2 days agoFix T65955: GPencil: drawing shapes on surface causes intense viewport flickering
Antonioya [Sat, 22 Jun 2019 14:47:18 +0000 (16:47 +0200)]
Fix T65955: GPencil: drawing shapes on surface causes intense viewport flickering

There were some problems in the engine because the data was saved inside e_data struct, but this struct is reset sometimes and the background texture is not valid.

Now, the data has been moved to stl->g_data and all creation and free has been moved to use stl->g_data. This fix also some small memory leak for the Buffer GPUBatch data.

The background texture has been moved to texture list because must be available all the time. When is not drawing, the texture is removed to safe memory. Also, if the mode is painting and the texture is not ready because it was removed by Draw Manager, the texture is reloaded with the background image again. This ensure the background image is always visible when painting.

Also I have used this patch to reduce the size of texture used for background to 16F instead of 32F and the blank texture to 1x1 pixels instead of 16x16.

Reviewed by: @fclem

See D5115 for more details

2 days agomacOS: tweaks for macOS bundle script
Brecht Van Lommel [Sat, 22 Jun 2019 13:51:35 +0000 (15:51 +0200)]
macOS: tweaks for macOS bundle script

* Follow Blender code style a bit more closely
* Fix mixed tabs and spaces
* Remove old README now that it's part of the script
* Make less tied to specific Blender version numbers

2 days agoNodes: show shader -> other socket type as invalid link
Brecht Van Lommel [Sat, 22 Jun 2019 13:36:29 +0000 (15:36 +0200)]
Nodes: show shader -> other socket type as invalid link

2 days agoCleanup: add braces
Campbell Barton [Sat, 22 Jun 2019 13:06:02 +0000 (23:06 +1000)]
Cleanup: add braces

2 days agoKeymap: Add Alt-A, Ctrl-I to file-select space
Campbell Barton [Sat, 22 Jun 2019 10:13:56 +0000 (20:13 +1000)]
Keymap: Add Alt-A, Ctrl-I to file-select space

2 days agoFile Selector: add options to select all operator
Campbell Barton [Sat, 22 Jun 2019 10:10:53 +0000 (20:10 +1000)]
File Selector: add options to select all operator

Add common select options (toggle/invert etc).

2 days agoCleanup: use doxy groups
Campbell Barton [Sat, 22 Jun 2019 08:52:34 +0000 (18:52 +1000)]
Cleanup: use doxy groups

2 days agoUI: remove Visible IPO icons
Campbell Barton [Sat, 22 Jun 2019 05:04:46 +0000 (15:04 +1000)]
UI: remove Visible IPO icons

These are duplicates of HIDE_ON/OFF.

2 days agoGPU_matrix: Add GPU_matrix_unproject_precalc
Campbell Barton [Sat, 22 Jun 2019 03:19:11 +0000 (13:19 +1000)]
GPU_matrix: Add GPU_matrix_unproject_precalc

Pre-calculates values needed for unprojecting to avoid
a matrix invert and extracting projection matrix dimensions for
every call to GPU_matrix_unproject.

Use for gizmo selection drawing.

2 days agoCleanup: redundant static set use
Campbell Barton [Sat, 22 Jun 2019 01:08:12 +0000 (11:08 +1000)]
Cleanup: redundant static set use

2 days agoCleanup: assign strip type to a variable before use (call strip_type)
Campbell Barton [Sat, 22 Jun 2019 01:02:33 +0000 (11:02 +1000)]
Cleanup: assign strip type to a variable before use (call strip_type)

This was only done in some parts of the sequencer UI,
existing vars were named seq_type & stype.

2 days agoCleanup: sequencer source panel
Campbell Barton [Sat, 22 Jun 2019 00:50:10 +0000 (10:50 +1000)]
Cleanup: sequencer source panel

Split sound from image/movie branch (since image/movie share logic).

2 days agoFix error in recent UI changes
Campbell Barton [Sat, 22 Jun 2019 00:46:33 +0000 (10:46 +1000)]
Fix error in recent UI changes

Image file is meant to be next to the directory in the Source panel.

2 days agoFix sub-panel UI offset
Campbell Barton [Fri, 21 Jun 2019 23:54:49 +0000 (09:54 +1000)]
Fix sub-panel UI offset

The offset for check-boxes in sub-panels wasn't being scaled correctly.

2 days agoCleanup: warnings, formatting
Campbell Barton [Sat, 22 Jun 2019 00:10:13 +0000 (10:10 +1000)]
Cleanup: warnings, formatting

2 days agomacOS: install license files inside Blender.app bundle
Brecht Van Lommel [Fri, 21 Jun 2019 17:05:15 +0000 (19:05 +0200)]
macOS: install license files inside Blender.app bundle

Since we are planning to install Blender as /Applications/Blender.app without
being contained in a folder.

2 days agomacOS: rename blender.app to Blender.app
Brecht Van Lommel [Fri, 21 Jun 2019 16:12:00 +0000 (18:12 +0200)]
macOS: rename blender.app to Blender.app

Using a capitalized app name fits the platform guidelines. Since macOS file
systems are case insensitive by default this should not break scripts that
assume lowercase.

3 days agoUI: Remove redundant Running Jobs from Sequencer header.
William Reynish [Fri, 21 Jun 2019 18:34:24 +0000 (20:34 +0200)]
UI: Remove redundant Running Jobs from Sequencer header.

You would see the running jobs thrice, once in each Sequencer header and in the Status Bar too.
One instance of this is more than enough.

3 days agoUI: Use enum for Sequencer vs 3D Camera input in Scene panel in Sequencer sidebar
William Reynish [Fri, 21 Jun 2019 18:01:08 +0000 (20:01 +0200)]
UI: Use enum for Sequencer vs 3D Camera input in Scene panel in Sequencer sidebar

Also move Time and Source below other panels for consistency

3 days agomacOS DMG bundle, codesign and notarization script
Arto Kitula [Fri, 21 Jun 2019 17:30:17 +0000 (20:30 +0300)]
macOS DMG bundle, codesign and notarization script

3 days agoUI: use force icon for objects in outliner, fix missing redraw when changing type
Alessio Monti di Sopra [Fri, 21 Jun 2019 16:22:53 +0000 (18:22 +0200)]
UI: use force icon for objects in outliner, fix missing redraw when changing type

Differential Revision: https://developer.blender.org/D5008

3 days agoFix small memory leak in Cycles principled BSDF
Brecht Van Lommel [Fri, 21 Jun 2019 16:02:43 +0000 (18:02 +0200)]
Fix small memory leak in Cycles principled BSDF

3 days agoAdd macOS disk image background image
William Reynish [Fri, 21 Jun 2019 16:10:25 +0000 (18:10 +0200)]
Add macOS disk image background image

3 days agoRename: Save custom Studio light > Save Custom Studio Light
Dalai Felinto [Fri, 21 Jun 2019 16:01:54 +0000 (13:01 -0300)]
Rename: Save custom Studio light > Save Custom Studio Light

3 days agomacOS: remove blenderplayer.app, don't include Blender Foundation in version
Brecht Van Lommel [Fri, 21 Jun 2019 15:59:31 +0000 (17:59 +0200)]
macOS: remove blenderplayer.app, don't include Blender Foundation in version

3 days agoFix (harmless) Cycles ASAN warnings
Brecht Van Lommel [Fri, 21 Jun 2019 14:24:56 +0000 (16:24 +0200)]
Fix (harmless) Cycles ASAN warnings

3 days agoUI: Restore minimized windows when raising them
Harley Acheson [Fri, 21 Jun 2019 15:06:01 +0000 (08:06 -0700)]
UI: Restore minimized windows when raising them

Separate temporary windows, like Preferences, should be restored (if minimized) before bringing to top

Differential Revision: https://developer.blender.org/D5105

Reviewed by Brecht Van Lommel

3 days agoFix T65834: Circle Select does not update select_id buffer after orbiting view3d.
mano-wii [Fri, 21 Jun 2019 15:05:47 +0000 (12:05 -0300)]
Fix T65834: Circle Select does not update select_id buffer after orbiting view3d.

This solution checks if `persp_mat` has changed. If positive, the selection buffer is redrawn.

Differential Revision: https://developer.blender.org/D5081

3 days agoFix T63766: Multiresolution behavior when using crease edge
Sergey Sharybin [Fri, 21 Jun 2019 12:58:47 +0000 (14:58 +0200)]
Fix T63766: Multiresolution behavior when using crease edge

Switch to Gregory basis patches which are tangent continuous across their
boundaries.

Originally we've used BSpline basis patches to be more compatible with the
old subdivision code, but a lot of things changed anyway.

3 days agoFix T65957: Cycles crash with OSL and UV maps
Brecht Van Lommel [Fri, 21 Jun 2019 12:33:06 +0000 (14:33 +0200)]
Fix T65957: Cycles crash with OSL and UV maps

3 days agoFix T65948: boolean modifier does not merge UV maps with the same name
Brecht Van Lommel [Fri, 21 Jun 2019 12:12:50 +0000 (14:12 +0200)]
Fix T65948: boolean modifier does not merge UV maps with the same name

3 days agoUI: Add decorators to Sequencer sidebar
William Reynish [Fri, 21 Jun 2019 11:37:33 +0000 (13:37 +0200)]
UI: Add decorators to Sequencer sidebar

These items you are very likely to want to animate.
Only adding for panels where it makes sense, so not Time or Source.

3 days agoFix T65969: missing update of properties editor for Dyntopo checkbox
Alessio Monti di Sopra [Fri, 21 Jun 2019 11:29:49 +0000 (13:29 +0200)]
Fix T65969: missing update of properties editor for Dyntopo checkbox

Differential Revision: https://developer.blender.org/D5111

3 days agoFix error in recent sequencer UI update
Campbell Barton [Fri, 21 Jun 2019 11:18:57 +0000 (21:18 +1000)]
Fix error in recent sequencer UI update

Use of unset variable, however the value was already assigned

3 days agoFix T65976: switching to workbench engine in lookdev mode shows wrong state
Brecht Van Lommel [Fri, 21 Jun 2019 11:02:58 +0000 (13:02 +0200)]
Fix T65976: switching to workbench engine in lookdev mode shows wrong state

3 days agoRevert "Particle system: Move runtime data to runtime field"
Sergey Sharybin [Fri, 21 Jun 2019 09:49:43 +0000 (11:49 +0200)]
Revert "Particle system: Move runtime data to runtime field"

This reverts commit 36faf739a71624b6ca10cec7233779f9eeace0bd.

Somewhat annoying but this change had some unforeseen consequences,
which lead to an actual bug.

Since this change was not sufficient to get original report fixed
is easier to simply revert for now.

Fixes T65842: Hair disappears when clicking on particle system name

3 days agoFix: Alembic import segfault when importing mesh with null UVs
Sybren A. Stüvel [Fri, 21 Jun 2019 09:32:57 +0000 (11:32 +0200)]
Fix: Alembic import segfault when importing mesh with null UVs

This fixes an issue introduced in 4337bc2e6303dbd5f295878f3e7490995a62713a.

3 days agoFix: wrong greying out in Sequencer sub-panels
William Reynish [Fri, 21 Jun 2019 09:30:11 +0000 (11:30 +0200)]
Fix: wrong greying out in Sequencer sub-panels

3 days agoUI: Further tweaks to Sequencer sidebar:
William Reynish [Fri, 21 Jun 2019 09:22:56 +0000 (11:22 +0200)]
UI: Further tweaks to Sequencer sidebar:

  - Move strip name to the top (easier to see which strip you are adjusting, and more consistent with other areas)
  - Move Mute next to this, since it affects everything, both audio and video, and completely disables the clip
  - Mute now greys out all the Strip panels, since none of them apply if the strip is disabled
  - Rename Info to Time, since now this panel only includes timecodes and related controls
  - Move Lock to the Time header, since you are locking the time controls
  - Move clip resolution to Source, since it's not related to time

3 days agoFix T62876: Camera Background Images
Jeroen Bakker [Tue, 2 Apr 2019 14:05:22 +0000 (16:05 +0200)]
Fix T62876: Camera Background Images

Migrate old legacy code to the draw mamager/object mode. The old legacy
version did not work with wireframe. By migrating the code
to modern draw manager code we have mode control on the drawing process.

Still background images do not work with OIT, the cause seems to be that the transparent pixels are treated as background pixels.
Also There are some artifacts when working with Holdouts and DoF, this
is because the draw engines do not pass the correct alpha values.

Reviewers: fclem, brecht

Differential Revision: https://developer.blender.org/D4638

3 days agoFix T65745: Bone Selection X-Ray Drawing.
Jeroen Bakker [Thu, 20 Jun 2019 14:50:08 +0000 (16:50 +0200)]
Fix T65745: Bone Selection X-Ray Drawing.

The Pose Bone Selection used normal matric multiplication, but that
mismatched the Depth buffer from all draw engines. They used the
optimized matrices from common_view_lib.

This change will use the optimized version, so the depth buffer matches
and the render artifacts would be correct.

Please note that bone selection is not using shcfg and therefore render clipping is still off.

Reviewed By: fclem

Differential Revision: https://developer.blender.org/D5100

3 days agoCleanup: spelling, grammar, and other corrections
Campbell Barton [Thu, 20 Jun 2019 23:50:23 +0000 (09:50 +1000)]
Cleanup: spelling, grammar, and other corrections

D5084 by @nBurn with edits

3 days agoFix T65975: Memory leak adding movie sequence strip
Richard Antalik [Thu, 20 Jun 2019 23:06:01 +0000 (16:06 -0700)]
Fix T65975: Memory leak adding movie sequence strip

Reviewed By: campbellbarton

Differential Revision: https://developer.blender.org/D5106

3 days agoKeymap: toggle all gizmos with Ctrl-`
Campbell Barton [Thu, 20 Jun 2019 22:36:49 +0000 (08:36 +1000)]
Keymap: toggle all gizmos  with Ctrl-`

Was only toggling transform gizmos, which is too specific
in cases where users might want to remove gizmos from the view.

This also follows the top-level button which is most prominent in the UI.

3 days agoCleanup: use trailing commas for multi-line arguments
Campbell Barton [Thu, 20 Jun 2019 22:36:03 +0000 (08:36 +1000)]
Cleanup: use trailing commas for multi-line arguments

3 days agoCleanup: don't use plural for forward/backward enum
Campbell Barton [Thu, 20 Jun 2019 22:30:48 +0000 (08:30 +1000)]
Cleanup: don't use plural for forward/backward enum

Match existing enums.

Also use the term 'strip', instead of a 'clip'
(again, follow existing terminology, clip is used for movie-clip strips).

3 days agoFix dashed line drawing
Campbell Barton [Thu, 20 Jun 2019 22:24:58 +0000 (08:24 +1000)]
Fix dashed line drawing

The dash_factor wasn't being set in many places, having the graph editor
open for eg, caused box-select in the 3D view not to show dashes.

3 days agoFix T65960 Crash on entering Edit Mode of BesierCurve with modifiers
Clément Foucault [Thu, 20 Jun 2019 22:06:37 +0000 (00:06 +0200)]
Fix T65960 Crash on entering Edit Mode of BesierCurve with modifiers

3 days agoCleanup: sequencer UI code
Campbell Barton [Thu, 20 Jun 2019 21:32:03 +0000 (07:32 +1000)]
Cleanup: sequencer UI code

- Remove `str()` on strings.
- Remove duplicate layout assignment.
- Don't assigning sub-layouts the name 'layout' (hard to follow logic).
- Spaces around operators.
- Import smpte_from_frame name-space.

4 days agoUI: Tweak Sequencer Sidebar panels
William Reynish [Thu, 20 Jun 2019 17:11:39 +0000 (19:11 +0200)]
UI: Tweak Sequencer Sidebar panels

Even though we are in UI freeze, we agreed that this should be better, and so we are changing a few things:

  - Clearer separation of controls that affect the image transform vs the video
    - New Transform panel houses Flip X/Y, Offset and Crop
    - Flip X/Y now uses toggle buttons like we do for mirroring elsewhere (clearer + takes up less space)
  - Video panel only includes things that relate to playback, ie Playback Direction, Strobe etc.
  - Backwards/Forwards playback is now an enum rather than a toggle (we should always use enums when it's not an on/off switch)
  - Rename Input panel to Source
    - Just more immediately understandable and correct
    - Move Deinterlace here since it's source file dependent
    - Move Source panel to be a top level panel
  - Merge Info and Timecodes panels
    - Move Lock toggle to Info panel (was previously attached to name field which made no sense whatsoever)
    - Name field now uses full width and doesn't add redundant text in front of it
  - Re-arrange tabs to be Strip, Modifiers, Proxy & Cache, View
    - Strip and Modifiers should be together

Reviewers: brecht, iss

Differential Revision: https://developer.blender.org/D5098

4 days agoFix sequencer sidebar not being wide enough by default to show timecodes
Brecht Van Lommel [Thu, 20 Jun 2019 17:00:34 +0000 (19:00 +0200)]
Fix sequencer sidebar not being wide enough by default to show timecodes

4 days agoFix T64705: can't drive object visibility in collection instances
Brecht Van Lommel [Thu, 20 Jun 2019 16:30:35 +0000 (18:30 +0200)]
Fix T64705: can't drive object visibility in collection instances

Not the cleanest solution, but should be fine until we add support for driving
collection visibility and revise this system as a whole.

4 days agoFix T65802: F-curves modifiers in nodes doesn't updates properly
Sebastian Parborg [Thu, 20 Jun 2019 15:46:57 +0000 (17:46 +0200)]
Fix T65802: F-curves modifiers in nodes doesn't updates properly

The other built in modifiers, except the generator modifier, seems to
update the depsgraph thought some RNA magic.
However the generator seem to be a bit special and doesn't get included
into this. Now we manually update the depsgraph on value changes to the
generator modifier.

4 days agoFix sculpt mask not visible in EEVEE
Pablo Dobarro [Thu, 20 Jun 2019 15:03:04 +0000 (17:03 +0200)]
Fix sculpt mask not visible in EEVEE

Differential Revision: https://developer.blender.org/D5092

4 days agoFix T65775: UV projection is dependant of the object position
Sebastian Parborg [Thu, 20 Jun 2019 13:13:27 +0000 (15:13 +0200)]
Fix T65775: UV projection is dependant of the object position

The rotation matrix included the global object offset too. Now we only
take into account the actual offset that what sent to the function.

Reviewed By: Brecht

Differential Revision: http://developer.blender.org/D5094

4 days agoFix T65877: crash when baking in sculpt mode
Alexander Gordeev [Thu, 20 Jun 2019 12:11:20 +0000 (14:11 +0200)]
Fix T65877: crash when baking in sculpt mode

Also fixes bug where mesh with multires modifier is invisible in render
while in sculpt mode.

Differential Revision: https://developer.blender.org/D5099

4 days agoCleanup: Remove unused depsgraph function
Sergey Sharybin [Thu, 20 Jun 2019 08:31:05 +0000 (10:31 +0200)]
Cleanup: Remove unused depsgraph function

4 days agoFix T65806: Can't Access bpy.context inside Application Timer
Sergey Sharybin [Thu, 20 Jun 2019 08:28:52 +0000 (10:28 +0200)]
Fix T65806: Can't Access bpy.context inside Application Timer

Sound synchronization was messing a bit with the context, for, actually,
no reason.

Use more direct queries rather than relying on a context there.

4 days agoFix T65770: File Browser missing "Sidebar" in View menu
Campbell Barton [Thu, 20 Jun 2019 04:49:55 +0000 (14:49 +1000)]
Fix T65770: File Browser missing "Sidebar" in View menu

4 days agoFix T65922: Custom property error
Campbell Barton [Thu, 20 Jun 2019 04:34:20 +0000 (14:34 +1000)]
Fix T65922: Custom property error

5 days agoFix sculpt not updating on undo with EEVEE enabled
Pablo Dobarro [Wed, 19 Jun 2019 18:29:25 +0000 (20:29 +0200)]
Fix sculpt not updating on undo with EEVEE enabled

5 days agoFix T65398 - Fix frame rate base use in Python SMPTE functions
Richard Antalik [Wed, 19 Jun 2019 17:49:37 +0000 (10:49 -0700)]
Fix T65398 - Fix frame rate base use in Python SMPTE functions

Differential Revision: https://developer.blender.org/D5064

Reviewed By: brecht

5 days agoVSE: Draw pre-animated (volume) sound strip waveforms.
Richard Antalik [Wed, 19 Jun 2019 17:36:45 +0000 (10:36 -0700)]
VSE: Draw pre-animated (volume) sound strip waveforms.

5 days agoFix T65780: unnecessary GPU image texture reloads after recent changes
Brecht Van Lommel [Wed, 19 Jun 2019 15:49:39 +0000 (17:49 +0200)]
Fix T65780: unnecessary GPU image texture reloads after recent changes

5 days agoGPencil: Remove unreported duplicated Reproject operator in menu
Antonioya [Wed, 19 Jun 2019 15:19:22 +0000 (17:19 +0200)]
GPencil: Remove unreported duplicated Reproject operator in menu

The reproject option was duplicated. Detected writing the manual.

5 days agoFix order of modifications for Set Origin.
Sergey Sharybin [Wed, 19 Jun 2019 12:36:07 +0000 (14:36 +0200)]
Fix order of modifications for Set Origin.

The logic of parent update is very similar to Apply Transform, so made it
so parents are handled before children.

5 days agoFix T65900: Apply Scale doesn't work correct with parenting
Sergey Sharybin [Wed, 19 Jun 2019 12:12:34 +0000 (14:12 +0200)]
Fix T65900: Apply Scale doesn't work correct with parenting

Parents are to be handled prior to their children.

5 days agoFix T65614: Sequencer render single layer only
Sergey Sharybin [Wed, 19 Jun 2019 14:00:38 +0000 (16:00 +0200)]
Fix T65614: Sequencer render single layer only

Was noticeable when sequencer uses scene with a compositor.

The way it was using render API was forcing a single render layer.

Reviewers: brecht

Reviewed By: brecht

Differential Revision: https://developer.blender.org/D5095

5 days agoFix T65914: Workbench Transparency Film
Jeroen Bakker [Wed, 19 Jun 2019 14:20:02 +0000 (16:20 +0200)]
Fix T65914: Workbench Transparency Film

When performing F12 render on a transparent film all solid objects where
a bit transparent. Single Pass AA and no AA passes were not visible at
all.

Issue was that the first frame was not handled correctly making these
artifacts. This commit changes the order of `GPU_state_init` and
`DRW_state_reset` so the state is correct during the first pass.

5 days agoBring mask tools back to Masking Tool Area and update Context Menu
Sebastian Koenig [Wed, 19 Jun 2019 13:05:25 +0000 (15:05 +0200)]
Bring mask tools back to Masking Tool Area and update Context Menu

The mask tools in the Tool Area of Clip Editor where never brought back,
after decision was made to postpone proper masking tools to 2.81.

This brings back the Mask Tool Panel in the Mask tab of Masking Tool Area.

This Diff also adds a better Context Menu, which respects whether you're
in Masking or Tracking mode. I have added the most important operators
there, with a focus on those that are otherwise harder to access.

Reviewers: sergey, billreynish

Subscribers: sebastian, brecht, hype

Tags: #motion_tracking

Differential Revision: https://developer.blender.org/D5075

5 days agoFix T65902: save all modified images should not try to save .psd files
Brecht Van Lommel [Wed, 19 Jun 2019 12:28:54 +0000 (14:28 +0200)]
Fix T65902: save all modified images should not try to save .psd files

We can't save these without data loss, so don't try to do this.

5 days agoCleanup: Pass explicit dependency graph
Sergey Sharybin [Wed, 19 Jun 2019 10:15:10 +0000 (12:15 +0200)]
Cleanup: Pass explicit dependency graph

Avoids hash lookup on per-object basis when applying transform.

5 days agoFix T65918 DRW: Crash when add a any modifier to a curve
Clément Foucault [Wed, 19 Jun 2019 10:20:55 +0000 (12:20 +0200)]
Fix T65918 DRW: Crash when add a any modifier to a curve

5 days agoIndustry Compat keymap: Some curve edit keymap entries were using Click events
William Reynish [Wed, 19 Jun 2019 08:29:15 +0000 (10:29 +0200)]
Industry Compat keymap: Some curve edit keymap entries were using Click events

This was inconsistent and make the actions seem slow and unresponsive. Change to using Press, like other modes.

5 days agoUI: show label in tool-tips
Campbell Barton [Wed, 19 Jun 2019 01:38:06 +0000 (11:38 +1000)]
UI: show label in tool-tips

When button text doesn't already show the label,
include the label in the tool-tip.

Without this the descriptions for icon-only buttons
don't always make sense.

This also gives a tool-tip for icon-only popovers.

5 days agoUI: add popover access for button labels
Campbell Barton [Wed, 19 Jun 2019 01:34:54 +0000 (11:34 +1000)]
UI: add popover access for button labels

Needed for tool-tips to access labels.

5 days agoFix button label access returning empty label
Campbell Barton [Wed, 19 Jun 2019 01:29:51 +0000 (11:29 +1000)]
Fix button label access returning empty label

The check the buttons string has content (not just that it's non-NULL).

5 days agoFix active face-dot color
Campbell Barton [Wed, 19 Jun 2019 00:42:32 +0000 (10:42 +1000)]
Fix active face-dot color

Unlike edge/vert this was blending with the regular selection color.

5 days agoMove to Collection: Fix tooltip
Dalai Felinto [Tue, 18 Jun 2019 23:45:48 +0000 (20:45 -0300)]
Move to Collection: Fix tooltip

Found this while writing the manual page. A scene collection nowadays is simply
called collection.

5 days agoUI: add set upper/lowercase to edit-text menu
Campbell Barton [Tue, 18 Jun 2019 22:21:25 +0000 (08:21 +1000)]
UI: add set upper/lowercase to edit-text menu

Lost when toolbar was removed.

5 days ago3D View: draw edit-text selection on-top (x-ray)
Campbell Barton [Tue, 18 Jun 2019 22:00:47 +0000 (08:00 +1000)]
3D View: draw edit-text selection on-top (x-ray)

This changes behavior from 2.7x, where selection & cursor could be
occluded by other objects.

Doing this without z-fighting in 2.8x isn't so simple because drawing
the text geometry is separated from edit-selection.

Change behavior since this doesn't seem like an important difference.

Fixes assert drawing text edit mode.

5 days agoCleanup: style, indentation
Campbell Barton [Tue, 18 Jun 2019 21:24:55 +0000 (07:24 +1000)]
Cleanup: style, indentation

5 days agoCMake: cleanup, unset temporary var after use
Campbell Barton [Tue, 18 Jun 2019 21:12:16 +0000 (07:12 +1000)]
CMake: cleanup, unset temporary var after use

6 days agoMeshBatchCache: Speedup: Do not return valid batch if geometry is empty
Clément Foucault [Tue, 18 Jun 2019 20:25:37 +0000 (22:25 +0200)]
MeshBatchCache: Speedup: Do not return valid batch if geometry is empty

There was a huge overhead of batches that had no geometry. The loose
wire batch was the culprit.

6 days agoFix T65631 Eevee: Translucent shader broken in Eevee when AO is enabled
Clément Foucault [Tue, 18 Jun 2019 16:28:35 +0000 (18:28 +0200)]
Fix T65631 Eevee: Translucent shader broken in Eevee when AO is enabled

6 days agoCleanup: GPU: Fix codestyle
Clément Foucault [Tue, 18 Jun 2019 16:11:16 +0000 (18:11 +0200)]
Cleanup: GPU: Fix codestyle

6 days agoFile Browser: Various fixes and enhancements to 'autoscroll to item' feature.
Bastien Montagne [Tue, 18 Jun 2019 19:44:14 +0000 (21:44 +0200)]
File Browser: Various fixes and enhancements to 'autoscroll to item' feature.

Initial trigger to this work was T65782, requesting faster autoscroll
when current folder contains thousands of items. That was a fairly
simple change, just needed to make scrolling steps variable based on
'distance' between current position and desired one.

But several other issues showed up while working on this, among the most
annoying ones, the scrolltimer could keep running forever in some cases,
failing to detect properly an 'end condition', we could even get some
'bouncing' in extreme corner cases, edited item was not always properly
visible in the end, etc.

So as usual with UI, this ended up in a frustrating equilibrium game of
finding the optimal solution among several tradeof, taking unexpected
large amount of time... At least new code seems to work OK in
all possible (reasonable) cases, that will do for now.

6 days agoFix Cycles CUDA suboptimal performance on Windows 10 with recent graphics cards
Brecht Van Lommel [Tue, 18 Jun 2019 16:30:48 +0000 (18:30 +0200)]
Fix Cycles CUDA suboptimal performance on Windows 10 with recent graphics cards

When compute preemption is available we schedule more work which is more
efficient. However the CUDA driver appears to be incorrectly reporting this as
unavailable, even though it should be supported starting with Windows 10 1803
and Pascal and Turing (10x0 and 20x0) graphics cards.

This reduces render time by about a 25% difference on our benchmark scenes. On
Linux compute preemption appears to be reported correctly.

6 days agoFix T65689 Geometry overlaps axis selector
Clément Foucault [Tue, 18 Jun 2019 14:14:17 +0000 (16:14 +0200)]
Fix T65689 Geometry overlaps axis selector

It seems that in 2.79 callbacks were drawn with depth test off by default.

6 days agoFix T65660 Mirror modifier didn't work with custom normals.
Howard Trickey [Tue, 18 Jun 2019 14:07:53 +0000 (10:07 -0400)]
Fix T65660 Mirror modifier didn't work with custom normals.

6 days agoFix T61912, T63297: error baking tangent space normal map with autosmooth
Brecht Van Lommel [Tue, 18 Jun 2019 13:51:17 +0000 (15:51 +0200)]
Fix T61912, T63297: error baking tangent space normal map with autosmooth

6 days agoFix T65901: Alembic crash on out-of-bounds UV indices
Sybren A. Stüvel [Tue, 18 Jun 2019 13:08:41 +0000 (15:08 +0200)]
Fix T65901: Alembic crash on out-of-bounds UV indices

An Alembic file saved by 3DS Max caused Blender to crash when importing.
Either the UV indices in the file are out of bounds or they are written
in a way we don't expect. In either case, this now no longer causes Blender
to crash.

6 days agoAdd a new function to recover the next shading group.
Antonioya [Tue, 18 Jun 2019 12:00:19 +0000 (14:00 +0200)]
Add a new function to recover the next shading group.

After talking with @fclem, we decided to keep this as a workaround function waiting for the clearing operation to be available inside the shgroups.

6 days agoFix T64153: RenderEngine.update_result does not show result immediately
Brecht Van Lommel [Tue, 18 Jun 2019 11:53:50 +0000 (13:53 +0200)]
Fix T64153: RenderEngine.update_result does not show result immediately

6 days agoFix T63359: no render preview when save buffers is on
Brecht Van Lommel [Tue, 18 Jun 2019 10:47:16 +0000 (12:47 +0200)]
Fix T63359: no render preview when save buffers is on

6 days agoCleanup: remove unused render buffers
Brecht Van Lommel [Tue, 18 Jun 2019 10:36:42 +0000 (12:36 +0200)]
Cleanup: remove unused render buffers

6 days agoFix --help text output
Campbell Barton [Tue, 18 Jun 2019 11:17:38 +0000 (21:17 +1000)]
Fix --help text output